Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Cascade soft deletion management #9534

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

adrien2p
Copy link
Member

What
Fix broken soft deletion depending on the object received

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 9:35am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 11, 2024 9:35am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 9:35am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 9:35am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 9:35am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 9:35am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 9:35am

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: d1438c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p
Copy link
Member Author

/snapshot-this

@adrien2p adrien2p changed the title fix(utils): Cascade sOCoft deletion management fix(utils): Cascade soft deletion management Oct 11, 2024
@adrien2p
Copy link
Member Author

/snapshot-this

Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 1d8939d

@olivermrbl
Copy link
Contributor

What was the broken scenario?

@adrien2p
Copy link
Member Author

adrien2p commented Oct 14, 2024

What was the broken scenario?

in some cases depending on the object, entity is not a function which was breaking the soft deletion entirely. Now it works in all cases. Also, since we haven't migrated our entire core to DML we didn't catch it and we didn't had tests on the DML for this. So I ve added it so that DML test the soft deletion itself as well

@adrien2p
Copy link
Member Author

@christiananese have you been able to give it a spin?

@olivermrbl olivermrbl merged commit 5a60a2a into develop Oct 14, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/dml-soft-delete branch October 14, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants